Skip to content

Commit 7df58ce

Browse files
dberenbaumdberenbaum
authored andcommitted
Revert "refactor notify_refs_to_studio"
This reverts commit c16d615.
1 parent 827e58f commit 7df58ce

File tree

3 files changed

+22
-21
lines changed

3 files changed

+22
-21
lines changed

dvc/repo/experiments/push.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from funcy import compact, group_by
55
from scmrepo.git.backend.base import SyncStatus
66

7+
from dvc.env import DVC_STUDIO_TOKEN, DVC_STUDIO_URL
78
from dvc.exceptions import DvcException
89
from dvc.log import logger
910
from dvc.repo import locked
@@ -31,26 +32,28 @@ def __init__(self, msg, result):
3132
def notify_refs_to_studio(
3233
repo: "Repo", git_remote: str, **refs: list[str]
3334
) -> Optional[str]:
34-
from dvc_studio_client.config import get_studio_config
35-
36-
from dvc.utils import studio
35+
import os
3736

37+
config = repo.config["studio"]
3838
refs = compact(refs)
3939
if not refs or env2bool("DVC_TEST"):
4040
return None
4141

42-
config = repo.config["studio"]
43-
config = get_studio_config(dvc_studio_config=config)
44-
token = config.get("token")
45-
studio_url = config.get("url")
42+
token = (
43+
os.environ.get(DVC_STUDIO_TOKEN)
44+
or os.environ.get("STUDIO_TOKEN")
45+
or config.get("token")
46+
)
4647
if not token:
4748
logger.debug("Studio token not found.")
4849
return None
49-
repo_url = studio.get_repo_url(repo, git_remote)
50-
if not repo_url:
51-
logger.debug("Git remote repo URL not found.")
52-
return None
5350

51+
from dulwich.porcelain import get_remote_repo
52+
53+
from dvc.utils import studio
54+
55+
_, repo_url = get_remote_repo(repo.scm.dulwich.repo, git_remote)
56+
studio_url = os.environ.get(DVC_STUDIO_URL) or config.get("url")
5457
d = studio.notify_refs(repo_url, token, base_url=studio_url, **refs)
5558
return d.get("url")
5659

dvc/repo/experiments/queue/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from dataclasses import asdict, dataclass
55
from typing import TYPE_CHECKING, Any, NamedTuple, Optional, Union
66

7-
from dvc_studio_client.config import get_studio_config
7+
from dvc_studio_client.post_live_metrics import get_studio_config
88
from funcy import retry
99

1010
from dvc.dependency import ParamsDependency

dvc/utils/studio.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,19 +128,17 @@ def get_subrepo_relpath(repo: "Repo") -> str:
128128
return "" if relpath == "." else relpath
129129

130130

131-
def get_repo_url(repo: "Repo", git_remote: Optional[str] = None) -> str | None:
131+
def get_repo_url(repo: "Repo") -> str:
132132
from dulwich.porcelain import get_remote_repo
133133

134134
from dvc.env import DVC_EXP_GIT_REMOTE
135135

136-
if not git_remote:
137-
git_remote = os.getenv(
138-
DVC_EXP_GIT_REMOTE, repo.config.get("exp", {}).get("git_remote")
139-
)
140-
if git_remote:
136+
repo_url = os.getenv(
137+
DVC_EXP_GIT_REMOTE, repo.config.get("exp", {}).get("git_remote")
138+
)
139+
if repo_url:
141140
try:
142-
_, repo_url = get_remote_repo(repo.scm.dulwich.repo, git_remote)
143-
return repo_url
141+
_, repo_url = get_remote_repo(repo.scm.dulwich.repo, repo_url)
144142
except IndexError:
145143
pass
146-
return git_remote
144+
return repo_url

0 commit comments

Comments
 (0)