Skip to content

Commit 8b65f06

Browse files
committed
vega: Only escape field.
Unnecesary escaping for `title` and labels was added in #81.
1 parent b4dbe1c commit 8b65f06

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/dvc_render/vega.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def get_filled_template(
8181
f"Template '{self.template.name}' "
8282
f"is not using '{anchor}' anchor"
8383
)
84-
else:
84+
elif name in {"x", "y"}:
8585
value = self.template.escape_special_characters(value)
8686
content = self.template.fill_anchor(content, name, value)
8787

tests/test_vega.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,6 @@ def test_escape_special_characters():
173173
assert filled["data"]["values"][0] == datapoints[0]
174174
# field and title yes
175175
assert filled["encoding"]["x"]["field"] == "foo\\.bar\\[0\\]"
176-
assert filled["encoding"]["x"]["title"] == "foo\\.bar\\[0\\]"
176+
assert filled["encoding"]["x"]["title"] == "foo.bar[0]"
177177
assert filled["encoding"]["y"]["field"] == "foo\\.bar\\[1\\]"
178-
assert filled["encoding"]["y"]["title"] == "foo\\.bar\\[1\\]"
178+
assert filled["encoding"]["y"]["title"] == "foo.bar[1]"

0 commit comments

Comments
 (0)