Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing -Werror to pytest --nbmake has no effect #104

Open
garrison opened this issue May 22, 2023 · 1 comment
Open

Passing -Werror to pytest --nbmake has no effect #104

garrison opened this issue May 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@garrison
Copy link

Describe the bug
Passing -Werror to pytest --nbmake has no effect. It should, instead, cause the tests to fail if the code in a notebook causes a warning.

To Reproduce
Steps to reproduce the behavior:

  1. Create a notebook which emits a warning.
  2. Run it using pytest --nbmake --Werror **/*ipynb

Expected behavior
I expect tests to fail.
@garrison garrison mentioned this issue May 22, 2023
Draft
@alex-treebeard
Copy link
Member

hi @garrison, thanks for this report. We generally intend to follow conventions in pytest so I'll mark this one as a bug.

@alex-treebeard alex-treebeard added the bug Something isn't working label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garrison @alex-treebeard