Skip to content

Conversation

@WillLillis
Copy link
Member

It looks like the interpolation stack size check against TREE_SITTER_SERIALIZATION_BUFFER_SIZE wasn't updated when the two increments before the loop were added.

Fixes tree-sitter/tree-sitter#3416

@amaanq
Copy link
Member

amaanq commented Jun 30, 2024

thanks for the fix! just left one comment

@WillLillis
Copy link
Member Author

WillLillis commented Jun 30, 2024

Not super sure what's causing that one file to fail...I can take another look tomorrow

Edit: Unless I found the wrong copy, master branch seems to be failing to parse that file as well.

@reymondzzzz
Copy link

I'm interested in this fix. Could u make release in crate after merge. I reported that in main treesitter repo tree-sitter/tree-sitter#3416

@WillLillis
Copy link
Member Author

I'm interested in this fix. Could u make release in crate after merge. I reported that in main treesitter repo tree-sitter/tree-sitter#3416

They're probably holding off on merging this until the grammar issue causing the CI failure is addressed. I'll see if I can get a minimal reproduction and open a separate issue soon to help things move along.

@amaanq amaanq merged commit 939ff60 into tree-sitter:master Jul 4, 2024
@amaanq
Copy link
Member

amaanq commented Jul 4, 2024

thank you @WillLillis! sorry for being behind

@reymondzzzz
Copy link

@amaanq could you make release in cargo.io with this pr?

@WillLillis WillLillis deleted the misc branch July 8, 2024 14:48
@amaanq
Copy link
Member

amaanq commented Jul 8, 2024

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion `length <= TREE_SITTER_SERIALIZATION_BUFFER_SIZE' failed

3 participants