Skip to content

Commit 28dfbe4

Browse files
Brent1LTBrent Bumann
and
Brent Bumann
authored
Spec Update 11/17/2021 (dropbox#61)
Change Notes: file_tagging Namespace - Add BaseTagError unions - Remove BaseError, BaseTagError extends BaseError unions - Update RemoveTagError extends BaseTagError union to remove tag_not_exists_for_this_path - Update RemoveTagError extends BaseTagError union to include tag_not_present - Update Comments Co-authored-by: Brent Bumann <bbumann@dropbox.com>
1 parent 6e0a08f commit 28dfbe4

File tree

1 file changed

+4
-19
lines changed

1 file changed

+4
-19
lines changed

file_tagging.stone

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15,30 +15,15 @@ union Tag
1515
user_generated_tag = default
1616

1717

18-
union BaseError
19-
unknown
20-
"Action failed."
21-
transient
22-
"Action failed. Try again."
23-
input_validation
24-
"Action failed due to wrong params."
25-
cancelled
26-
"Action cancelled."
27-
2818
struct UserGeneratedTag
2919
tag_text TagText
3020

3121
example default
3222
tag_text = "my_tag"
3323

3424

35-
36-
union BaseTagError extends BaseError
37-
feature_not_supported
38-
"Tags are not turned on for your team. Please turn on the feature."
39-
40-
path_not_found
41-
"Path not found."
25+
union BaseTagError
26+
path LookupError
4227

4328

4429
#####################################
@@ -57,7 +42,7 @@ struct AddTagArg
5742

5843
union AddTagError extends BaseTagError
5944
too_many_tags
60-
"Item already has max supported tags."
45+
"The item already has the maximum supported number of tags."
6146

6247
route tags/add(AddTagArg, Void, AddTagError)
6348
"Add a tag to an item. A tag is a string. No more than 20 tags can be added to a given item."
@@ -84,7 +69,7 @@ struct RemoveTagArg
8469
tag_text = "MyTag"
8570

8671
union RemoveTagError extends BaseTagError
87-
tag_not_exists_for_this_path
72+
tag_not_present
8873
"That tag doesn't exist at this path."
8974

9075
route tags/remove(RemoveTagArg, Void, RemoveTagError)

0 commit comments

Comments
 (0)