Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Typhoeus requirement #727

Closed
BanzaiMan opened this issue Mar 24, 2020 · 1 comment · Fixed by #756
Closed

Drop Typhoeus requirement #727

BanzaiMan opened this issue Mar 24, 2020 · 1 comment · Fixed by #756
Milestone
v1.9.0

Comments

@BanzaiMan
Copy link
Contributor

BanzaiMan commented Mar 24, 2020 •
edited
Loading

It introduces dependency on ffi via ethon, which might be a problem for some.

As this is used as a Faraday adapter, dropping it should not be considered critical.

We should still use Tyhhoeus if it is available, though.
@BanzaiMan BanzaiMan added this to the v1.9.0 milestone Mar 24, 2020
@BanzaiMan
Copy link
Contributor Author

See #337

@BanzaiMan BanzaiMan mentioned this issue Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

Drop Typhoeus requirement travis-ci/travis.rb
1 participant
@BanzaiMan