@uppy/tus: fix event upload-success response.body.xhr

[ItsOnlyBinary]

this.resetUploaderReferences(file.id) causes the xhr object to be reset to empty XMLHttpRequest

This patch fires the upload-success event before calling this.resetUploaderReferences(file.id)

to test this patch try:

uppy.on('upload-success', (file, response) => {
    const xhr = response.body.xhr;
    console.log('upload-success', xhr.readyState);

    // readyState should be `4` which is the DONE state, before this patch it was always `0`
    // https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/readyState 
});

Related: #5444, #5456

[github-actions]

Diff output files

diff --git a/packages/@uppy/tus/lib/index.js b/packages/@uppy/tus/lib/index.js
index 8ebdeff..8fdf8ed 100644
--- a/packages/@uppy/tus/lib/index.js
+++ b/packages/@uppy/tus/lib/index.js
@@ -233,9 +233,9 @@ function _uploadLocalFile2(file) {
           xhr: payload.lastResponse.getUnderlyingObject(),
         },
       };
+      this.uppy.emit("upload-success", this.uppy.getFile(file.id), uploadResp);
       this.resetUploaderReferences(file.id);
       queuedRequest.done();
-      this.uppy.emit("upload-success", this.uppy.getFile(file.id), uploadResp);
       if (upload.url) {
         const {
           name,

[Murderlon]

Thanks a lot!