Conversation
Member
Author
|
Got a passing build here now https://travis-ci.org/transloadit/node-sdk/builds/193780317 |
Member
|
Alright, cheers. Thanks for doing this. <3 Going to check for integration tests and then review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @tim-kos @adrusi, not sure if you want this change, but I'm using increasingly complex projects to stress-test 🌿 Invig and the node-sdk was a good step up in the chain.
If you don't like it, that's ok. I'll have gained more experience and invig is better because of it already, making it a slightly better fit for the next step in complexity.
PS The tests pass locally for me (but I have not run integration tests)