Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to HTML5 history API #5080

Open
julen opened this issue Aug 15, 2016 · 0 comments
Open

Switch to HTML5 history API #5080

julen opened this issue Aug 15, 2016 · 0 comments

Comments

@julen
Copy link
Contributor

julen commented Aug 15, 2016

The editor and part of the reports' client-side code are using an old, jQuery-based, hashchange-event-based router which has been doing its job — however HTML5 wasn't a thing implemented in browsers back when this router was introduced, this being the only approach to client-side routing.

At the moment we are seeing the limits of it though. For instance, sometimes the state of the app cannot be kept in sync with the URL without appending a new browser history entry.

As of today pushState()/replaceState() along with the onpopstate event are well-supported in browsers and it is the way to go, so we should eventually switch to using it instead.

@unho unho added this to the 2.8.x milestone Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants