Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Suggestion.translator_comment_f #4434

Open
julen opened this issue Jan 28, 2016 · 3 comments
Open

Get rid of Suggestion.translator_comment_f #4434

julen opened this issue Jan 28, 2016 · 3 comments
Labels
Milestone

Comments

@julen
Copy link
Contributor

julen commented Jan 28, 2016

In 62e745e a translator_comment_f field was added to the Suggestion model, it has never been used though.

While there's a common will to improve the workflow for suggestions —for instance allowing reviewers to give a reason (#2596)—, at the moment this field is useless and there's no problem to bring anything similar back when enhancing the suggestions functionality.

@julen julen added the cleanup label Jan 28, 2016
@unho
Copy link
Member

unho commented Jan 28, 2016

+1 Storing review messages on a field with a different name would be better.

@julen
Copy link
Contributor Author

julen commented Jan 28, 2016

To clarify: I'm not proposing a rename, but getting rid of the field. If it's necessary any field like that can be added when working on improving the actual workflow.

@unho
Copy link
Member

unho commented Jan 28, 2016

To clarify: I agree with removing the field.

@phlax phlax added this to the 2.8.1 milestone Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants