Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wordcount function feature #4300

Open
unho opened this issue Dec 18, 2015 · 3 comments
Open

Refactor wordcount function feature #4300

unho opened this issue Dec 18, 2015 · 3 comments
Labels
Milestone

Comments

@unho
Copy link
Member

unho commented Dec 18, 2015

Right now Pootle allows to configure the wordcount function to use. There are two available functions: Pootle one and TTK one. Ideally both functions should be:

  • Merged together and
  • Placed in TTK (or in a separate package from Pootle and TTK)

Also Pootle should allow to set the wordcount function to use per project (like we do now for quality checks) instead of using a global setting.

@unho unho added the cleanup label Dec 18, 2015
@phlax phlax modified the milestones: 2.7.5, 2.7.4 Dec 18, 2015
@iafan
Copy link
Contributor

iafan commented Dec 22, 2015

What's the motivation behind having words counted differently for different projects?

@unho
Copy link
Member Author

unho commented Dec 22, 2015

This is to allow maximum configurability in a scenario where a single Pootle server has several projects for several customers (where each customer only sees its projects) and each customer wants to use their wordcount settings. So instead of using the notion of customer idea we think it is easier to set it by project.

@iafan
Copy link
Contributor

iafan commented Dec 22, 2015

Of course it's up to you if you want to share one Pootle instance between customers, but I bet if this this what you end up with, you will need to do many tweaks here and there to support multiple customers, and this might not be the optimal route. Virtual servers are very cheap now, so I'd suggest just using private instances of Pootle for each customer and not spending time on complicating the core codebase. Just my $0.02.

@unho unho removed their assignment Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants