Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple store creation from filesystem templates #4222

Open
phlax opened this issue Nov 25, 2015 · 3 comments
Open

Decouple store creation from filesystem templates #4222

phlax opened this issue Nov 25, 2015 · 3 comments

Comments

@phlax
Copy link
Member

phlax commented Nov 25, 2015

We should use the templates/src language from the db.

The only implication of this is that it means that template/src langs must be created first (this may happen already)

@phlax phlax added this to the 2.7.4 milestone Nov 25, 2015
@phlax phlax self-assigned this Nov 25, 2015
@dwaynebailey
Copy link
Member

@phlax are we reading the FS when we init a language? Even though we've loaded files in Templates lang? Ouch.

There are cases where you might not have a template language. So I'd say you must have a templates language first if you want the TP to be initialised from templates. But not having a template language shouldn't block creating a TP, as you might load it from external files without needing templates.

@unho
Copy link
Member

unho commented Nov 25, 2015

There are cases where you might not have a template language. So I'd say you must have a templates language first if you want the TP to be initialised from templates. But not having a template language shouldn't block creating a TP, as you might load it from external files without needing templates.

This is exactly the previous behavior.

@unho
Copy link
Member

unho commented Sep 30, 2016

Adding a new TP from the UI will benefit from this, since it already requires the templates files to exist on disk then creates new TP files on disk and then imports them to the DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants