Add Bilibili support #584
Open
Add Bilibili support #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AgainstEntropy is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @react-icons/all-files@4.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bilibili is one of the mainstream video paltforms in China. I believe there are people willing to demonstrate their bilibili accounts (with a unique Bilibili uid).
Changes made:
@react-icons/all-fileswithreact-icons(this was also mentioned in other PRs, such as Enhancement: Discord Added for Social links and footer and use react-icons instead #427 )Additional comments:
The theme color of Bilibili (#FB7299) was adopted
The replacement of
@react-icons/all-fileswithreact-iconsretained perfect support for all original icons and barely increased space usageWhat's more, this can also benifit new XTwitter logo #542. In order not to intertwine the issues, I will create another PR to update the
FaTwittericon toFaXTwitterNotion Test Page ID
Since it is not a feature related to any specific notion page, a deployment demo was attached below.
https://against-entropy-1f42yweim-ethans-projects-e52db79b.vercel.app/
Hope it's enought for verification and debugging~