Add a GitHub Action for checking and building prs #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
reviewed
Oct 25, 2023
| username: ${{ secrets.CONTAINER_REGISTRY_USER }} | ||
| password: ${{ secrets.CONTAINER_REGISTRY_PASSWORD }} | ||
|
|
||
| - uses: docker/build-push-action@v5 |
There was a problem hiding this comment.
This probably doesn't work because the current docker/Dockerfile doesn't build the binary. I can add this to my to-do list, but it may have to wait until the end of next week.
There was a problem hiding this comment.
No rush. I was just trying to give you a bit of a head start since I have a little experience with Actions.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work as a replacement to TravisCI.
It doesn't do the deployment part of course because I'm not really sure what that travis file is doing right now for deployments and it is harder for me to test.Added a deployment action... can't test and the tagging scheme for the platforms is slightly different I think. Basically... it is a starting point. I Probably won't be able to get this pr fully across the finish line alone.