Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to v2 addon #60

Closed
2 of 6 tasks
SergeAstapov opened this issue Mar 15, 2022 · 5 comments · Fixed by #64
Closed
2 of 6 tasks

Convert to v2 addon #60

SergeAstapov opened this issue Mar 15, 2022 · 5 comments · Fixed by #64
Assignees

Comments

@SergeAstapov
Copy link
Collaborator

SergeAstapov commented Mar 15, 2022

As this addon provides only run-time functionality hence it's the great candidate for v2 addon conversion.

My thought process is following:

  1. land Move ember-cli-htmlbars to devDependencies #57, Bump eslint-plugin-qunit from 7.0.0 to 7.2.0 #58, Run ember-cli-update to v4.2 to align with the latest addon blueprint #59
  2. release new minor 1.3.0
  3. land Drop Node.js 8, 10, 11, 13, 15 support #44
  4. convert to monorepo Convert to monorepo #63
  5. convert addon to v2
  6. release new major 2.0.0

@chriskrycho any thoughts, concerns?

@SergeAstapov SergeAstapov self-assigned this Mar 15, 2022
@chriskrycho
Copy link
Contributor

chriskrycho commented Mar 15, 2022

On this one, that seems good to me here, with the caveat that we need to cut a minor release bumping this to use the latest major of tracked-maps-and-sets first—that unblocks some consumers who are unable to use the current major of this at the same time as they are using the current major of tracked-built-ins, which is depending on a newer version of tracked-maps-and-sets.

@SergeAstapov
Copy link
Collaborator Author

SergeAstapov commented Mar 18, 2022

@chriskrycho now I got what you meant. However this addon does not depend on tracked-maps-and-sets any more.

Which means you may cut minor right now and I'll start working on v2 conversion which indeed will be slated for next major.

Update: created #63 which we can land once minor release goes out.

@chriskrycho
Copy link
Contributor

Ah, nice – I didn't remember that. Very good! I'll cut a minor release tomorrow bundling up all the stuff we've done lately and then we can get a new major out.

@boris-petrov
Copy link
Contributor

@chriskrycho - still waiting on this release! :)

@SergeAstapov SergeAstapov linked a pull request Apr 29, 2022 that will close this issue
@SergeAstapov
Copy link
Collaborator Author

Created #65 instead of this one as v2 addon format is just part of the major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants