Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Remove @cached #209

Open
elwayman02 opened this issue Aug 30, 2024 · 2 comments
Open

Breaking Change: Remove @cached #209

elwayman02 opened this issue Aug 30, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@elwayman02
Copy link

Now that it's built into Ember, we should deprecate @cached in this library and release a major version dropping support versions for Ember prior to it being added (4.1, I think?).

@NullVoxPopuli
Copy link

if the behavior is the same, the implementation could be a re-export, no need for breaking change.

and then we could deprecate usage of @cached from this library -- and provide a codemod to move to built in

@SergeAstapov SergeAstapov added the enhancement New feature or request label Sep 3, 2024
@SergeAstapov
Copy link
Collaborator

re-export with deprecation seems feasible to me.

as for codemod, seems like could be similar to https://github.com/ijlee2/ember-codemod-remove-inject-as-service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants