Skip to content

Commit 942d8b0

Browse files
committed
[ATTR] More robust attr parsing (apache#33)
1 parent d781a57 commit 942d8b0

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

nnvm/include/nnvm/tuple.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,6 @@ class Tuple {
202202
if (it != begin) os << ',';
203203
os << *it;
204204
}
205-
// python style tuple
206-
if (t.ndim() == 1) os << ',';
207205
os << ']';
208206
return os;
209207
}

nnvm/python/nnvm/top/attr_dict.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,17 @@ def get_bool(self, key):
9494
value : bool
9595
The result value
9696
"""
97-
return self[key] != "False"
97+
lowercase = self[key].lower()
98+
if lowercase == "1":
99+
return True
100+
elif lowercase == "0":
101+
return False
102+
elif lowercase == "true":
103+
return True
104+
elif lowercase == "false":
105+
return False
106+
else:
107+
raise ValueError("Wrong bool format for key %s" % key)
98108

99109
def __repr__(self):
100110
return str({k : self[k] for k in self.keys()})

0 commit comments

Comments
 (0)