Added handling redirections with curl if safe_mode or open_basedir is enabled. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| private function curl_exec_follow(/*resource*/ $ch, /*int*/ &$maxredirect = null) { | ||
| $mr = $maxredirect === null ? 5 : intval($maxredirect); | ||
| if (ini_get('open_basedir') == '' && ini_get('safe_mode' == 'Off')) { |
There was a problem hiding this comment.
You copied the typo from the original comment. Should be:
if (ini_get('open_basedir') == '' && ini_get('safe_mode') == 'Off') {
|
I've just used @r15ch13 fix on my Linux system which is secured with ASL (Atomic Secured Linux), and his patch managed to allow me to use the script without having to disable open_basedir, which as you know isn't a great idea to disable as it would open you up to a world of security issues. Thanks @r15ch13 you saved my bacon :) |
tpyo
added a commit
that referenced
this pull request
Mar 4, 2014
|
I'm terribly sorry that I haven't gotten around to testing this yet. I've copied your changes into fix/safemode-redirect for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling redirections with curl if safe_mode or open_basedir is enabled.
See: http://de3.php.net/manual/de/function.curl-setopt.php#102121