From 5e28aff15cea3873ec4c999c852071482e8394d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bern=C3=A1t=20G=C3=A1bor?= Date: Mon, 31 Jul 2023 09:51:18 -0700 Subject: [PATCH] Remove broken link (#3072) --- .pre-commit-config.yaml | 2 +- docs/changelog/3072.doc.rst | 1 + docs/development.rst | 9 ++++----- pyproject.toml | 8 ++++---- 4 files changed, 10 insertions(+), 10 deletions(-) create mode 100644 docs/changelog/3072.doc.rst diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 9cf29229d..a6e6f3497 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -27,7 +27,7 @@ repos: rev: 1.15.0 hooks: - id: blacken-docs - additional_dependencies: [black==23.3] + additional_dependencies: [black==23.7] - repo: https://github.com/astral-sh/ruff-pre-commit rev: "v0.0.280" hooks: diff --git a/docs/changelog/3072.doc.rst b/docs/changelog/3072.doc.rst new file mode 100644 index 000000000..955ab5679 --- /dev/null +++ b/docs/changelog/3072.doc.rst @@ -0,0 +1 @@ +Fix broken links - by :user:`gaborbernat`. diff --git a/docs/development.rst b/docs/development.rst index 9d16acf6b..b95d542de 100644 --- a/docs/development.rst +++ b/docs/development.rst @@ -132,11 +132,10 @@ must have legal permission to distribute any code you contribute to tox and it m Provide tests that cover your changes and run the tests locally first. tox :ref:`supports ` multiple Python versions and operating systems. Any pull request must consider and work on all these platforms. -Pull requests should be small to facilitate review. Keep them self-contained, and limited in scope. `Studies have shown -`_ that review quality falls off as patch size -grows. Sometimes this will result in many small PRs to land a single large feature. In particular, pull requests must -not be treated as "feature branches", with ongoing development work happening within the PR. Instead, the feature should -be broken up into smaller, independent parts which can be reviewed and merged individually. +Pull requests should be small to facilitate review. Keep them self-contained, and limited in scope. Studies have shown +that review quality falls off as patch size grows. In particular, pull requests must not be treated as +"feature branches", with ongoing development work happening within the PR. Instead, the feature should be broken up into +smaller, independent parts which can be reviewed and merged individually. Additionally, avoid including "cosmetic" changes to code that is unrelated to your change, as these make reviewing the PR more difficult. Examples include re-flowing text in comments or documentation, or addition or removal of blank lines diff --git a/pyproject.toml b/pyproject.toml index fb807f510..5ce1823be 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -54,12 +54,12 @@ dependencies = [ "filelock>=3.12.2", 'importlib-metadata>=6.7; python_version < "3.8"', "packaging>=23.1", - "platformdirs>=3.8.1", + "platformdirs>=3.9.1", "pluggy>=1.2", "pyproject-api>=1.5.3", 'tomli>=2.0.1; python_version < "3.11"', 'typing-extensions>=4.7.1; python_version < "3.8"', - "virtualenv>=20.23.1", + "virtualenv>=20.24.1", ] optional-dependencies.docs = [ "furo>=2023.5.20", @@ -76,8 +76,8 @@ optional-dependencies.testing = [ "covdefaults>=2.3", "detect-test-pollution>=1.1.1", "devpi-process>=0.3.1", - "diff-cover>=7.6", - "distlib>=0.3.6", + "diff-cover>=7.7", + "distlib>=0.3.7", "flaky>=3.7", "hatch-vcs>=0.3", "hatchling>=1.17.1",