Prefer compression encodings: brotli > gzip > deflate #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nehliin
approved these changes
Jan 26, 2023
|
Nice, thank you for reviewing! |
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the preference of compression encodings when multiple encodings are acceptable to the client at the same quality value. It prefers brotli over gzip over deflate, since that seems to be the general consensus as to which compression schemes are preferred when multiple are available.
I think this is a good default, since if the browser accepts brotli and gzip, and both the brotli and gzip features are enabled, the user would probably prefer brotli.