Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update com.thesamet.scalapb.scalapb-json4s to 0.12.1 #19

Merged

Conversation

qiwen-hu
Copy link
Contributor

@qiwen-hu qiwen-hu commented May 7, 2024

0.11.1 uses json4s-core 3.6.11; it is too old to be forward-compatible. We need to 4.0.6 in our projects.

The method is removed in 4.0.6

java.lang.NoSuchMethodError: 'org.json4s.JsonInput org.json4s.package$.string2JsonInput(java.lang.String)'
        at io.github.touchdown.gyremock.GrpcFromToJsonImpl.parseResp(GrpcFromToJson.scala:55)

@qiwen-hu
Copy link
Contributor Author

qiwen-hu commented May 8, 2024

Hi @touchdown, it still needs approval, and maybe only you could merge the PR?

@touchdown touchdown merged commit c06eb43 into touchdown:main May 8, 2024
3 checks passed
@touchdown touchdown added the chore label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants