feat(*): add turbo watch mode #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 92.9 kB ℹ️ View Unchanged
|
CodSpeed Performance ReportMerging #1201 will create unknown performance changesComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 65 65
Lines 599 599
Branches 123 123
=======================================
Hits 467 467
Misses 123 123
Partials 9 9
|
SEOKKAMONI
commented
Aug 7, 2024
package.json
Outdated
| "ci:sherif": "sherif --ignore-package \"./examples/*\" --ignore-package \"./websites/*\" --ignore-package \"./docs/*\" --ignore-dependency \"@tanstack/react-query\" ", | ||
| "ci:test": "turbo run ci:test", | ||
| "ci:test:watch": "turbo run ci:test:watch --parallel", | ||
| "ci:test:watch": "turbo watch ci:test", | ||
| "ci:test:watch:ui": "turbo run ci:test:watch:ui --parallel", |
There was a problem hiding this comment.
I named it ci:test:watch:ui because, unlike ci:test:watch which operates in turbo watch mode, this version has a more intuitive UI in the browser.
manudeli
reviewed
Aug 13, 2024
package.json
Outdated
Comment on lines
34
to
35
| "dev": "concurrently \"pnpm dev:build\" \"pnpm dev:test\"", | ||
| "dev:build": "turbo watch build --filter=./packages/**", |
There was a problem hiding this comment.
Suggested change
| "dev": "concurrently \"pnpm dev:build\" \"pnpm dev:test\"", | |
| "dev:build": "turbo watch build --filter=./packages/**", | |
| "dev": "concurrently \"pnpm dev:prepack\" \"pnpm dev:test\"", | |
| "dev:prepack": "turbo watch prepack", |
There was a problem hiding this comment.
That's such a great idea I didn't expect a double build, but thanks!
manudeli
requested changes
Aug 13, 2024
|
@manudeli The reason we use watch in prepack is to ensure that various aspects like build and eslint are properly checked during development. However, if we remove this, it will only perform a one-time check initially. Is this the direction we intended? |
manudeli
approved these changes
Aug 13, 2024
I had a misunderstanding. Since prepack is included in dependsOn for ci:test, when running in the development environment, modifying and saving code will cause the process to rerun from prepack through ci:test. This is why dev:prepack became unnecessary. |
2-NOW
pushed a commit
to 2-NOW/suspensive
that referenced
this pull request
Aug 16, 2024
# Overview close toss#1098 - add turbo watch mode - turbo watch mode continuously monitors for real-time code changes and automatically re-runs the task when modifications are detected. docs: https://turbo.build/repo/docs/reference/watch <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
close #1098
docs: https://turbo.build/repo/docs/reference/watch
PR Checklist