refactor(useCounter): Extract validateValue function and optimize performance #259
+15
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the
useCounter
hook by extracting thevalidateValue
function outside the hook and removing unnecessary memoization to improve performance and code maintainability.Reason for Change
The previous implementation had several inefficiencies:
validateValue
function was wrapped withuseCallback
and then memoized again, creating unnecessary computational overheadChanges Made
Omit<UseCounterOptions, 'step'>
Checklist
yarn run fix
to format and lint the code and docs?yarn run test:coverage
to make sure there is no uncovered line?