Skip to content

Commit ab7c7bb

Browse files
Mikulas Patockasnitm
authored andcommitted
dm: hold suspend_lock while suspending device during device deletion
__dm_destroy() must take the suspend_lock so that its presuspend and postsuspend calls do not race with an internal suspend. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Cc: stable@vger.kernel.org
1 parent 5f027a3 commit ab7c7bb

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/md/dm.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2638,10 +2638,16 @@ static void __dm_destroy(struct mapped_device *md, bool wait)
26382638
if (dm_request_based(md))
26392639
flush_kthread_worker(&md->kworker);
26402640

2641+
/*
2642+
* Take suspend_lock so that presuspend and postsuspend methods
2643+
* do not race with internal suspend.
2644+
*/
2645+
mutex_lock(&md->suspend_lock);
26412646
if (!dm_suspended_md(md)) {
26422647
dm_table_presuspend_targets(map);
26432648
dm_table_postsuspend_targets(map);
26442649
}
2650+
mutex_unlock(&md->suspend_lock);
26452651

26462652
/* dm_put_live_table must be before msleep, otherwise deadlock is possible */
26472653
dm_put_live_table(md, srcu_idx);

0 commit comments

Comments
 (0)