Skip to content

Commit 8dd9026

Browse files
committed
Merge branch 'sched-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
* 'sched-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip: sched, doc: Update sched-design-CFS.txt sched: Remove unused 'rq' variable and cpu_rq() call from alloc_fair_sched_group() sched.h: Fix a typo ("its") sched: Fix yield_to kernel-doc
2 parents 2a20b02 + 1232d61 commit 8dd9026

File tree

5 files changed

+4
-14
lines changed

5 files changed

+4
-14
lines changed

Documentation/scheduler/sched-design-CFS.txt

+1-6
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ This is the (partial) list of the hooks:
164164
It puts the scheduling entity (task) into the red-black tree and
165165
increments the nr_running variable.
166166

167-
- dequeue_tree(...)
167+
- dequeue_task(...)
168168

169169
When a task is no longer runnable, this function is called to keep the
170170
corresponding scheduling entity out of the red-black tree. It decrements
@@ -195,11 +195,6 @@ This is the (partial) list of the hooks:
195195
This function is mostly called from time tick functions; it might lead to
196196
process switch. This drives the running preemption.
197197

198-
- task_new(...)
199-
200-
The core scheduler gives the scheduling module an opportunity to manage new
201-
task startup. The CFS scheduling module uses it for group scheduling, while
202-
the scheduling module for a real-time task does not use it.
203198

204199

205200

include/linux/sched.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ struct thread_group_cputimer {
517517
struct autogroup;
518518

519519
/*
520-
* NOTE! "signal_struct" does not have it's own
520+
* NOTE! "signal_struct" does not have its own
521521
* locking, because a shared signal_struct always
522522
* implies a shared sighand_struct, so locking
523523
* sighand_struct is always a proper superset of

kernel/sched.c

+2-3
Original file line numberDiff line numberDiff line change
@@ -5473,6 +5473,8 @@ EXPORT_SYMBOL(yield);
54735473
* yield_to - yield the current processor to another thread in
54745474
* your thread group, or accelerate that thread toward the
54755475
* processor it's on.
5476+
* @p: target task
5477+
* @preempt: whether task preemption is allowed or not
54765478
*
54775479
* It's the caller's job to ensure that the target task struct
54785480
* can't go away on us before we can do any checks.
@@ -8449,7 +8451,6 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
84498451
{
84508452
struct cfs_rq *cfs_rq;
84518453
struct sched_entity *se;
8452-
struct rq *rq;
84538454
int i;
84548455

84558456
tg->cfs_rq = kzalloc(sizeof(cfs_rq) * nr_cpu_ids, GFP_KERNEL);
@@ -8462,8 +8463,6 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
84628463
tg->shares = NICE_0_LOAD;
84638464

84648465
for_each_possible_cpu(i) {
8465-
rq = cpu_rq(i);
8466-
84678466
cfs_rq = kzalloc_node(sizeof(struct cfs_rq),
84688467
GFP_KERNEL, cpu_to_node(i));
84698468
if (!cfs_rq)

kernel/sched_idletask.c

-2
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,4 @@ static const struct sched_class idle_sched_class = {
9494

9595
.prio_changed = prio_changed_idle,
9696
.switched_to = switched_to_idle,
97-
98-
/* no .task_new for idle tasks */
9997
};

kernel/sched_stoptask.c

-2
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,4 @@ static const struct sched_class stop_sched_class = {
102102

103103
.prio_changed = prio_changed_stop,
104104
.switched_to = switched_to_stop,
105-
106-
/* no .task_new for stop tasks */
107105
};

0 commit comments

Comments
 (0)