Skip to content

Commit 74f8e4b

Browse files
Peter ZijlstraIngo Molnar
Peter Zijlstra
authored and
Ingo Molnar
committed
sched: Remove rq argument to sched_class::task_waking()
In preparation of calling this without rq->lock held, remove the dependency on the rq argument. Reviewed-by: Frank Rowand <frank.rowand@am.sony.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Mike Galbraith <efault@gmx.de> Cc: Nick Piggin <npiggin@kernel.dk> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Link: http://lkml.kernel.org/r/20110405152729.071474242@chello.nl Signed-off-by: Ingo Molnar <mingo@elte.hu>
1 parent 7608dec commit 74f8e4b

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

include/linux/sched.h

+7-3
Original file line numberDiff line numberDiff line change
@@ -1048,8 +1048,12 @@ struct sched_domain;
10481048
#define WF_FORK 0x02 /* child wakeup after fork */
10491049

10501050
#define ENQUEUE_WAKEUP 1
1051-
#define ENQUEUE_WAKING 2
1052-
#define ENQUEUE_HEAD 4
1051+
#define ENQUEUE_HEAD 2
1052+
#ifdef CONFIG_SMP
1053+
#define ENQUEUE_WAKING 4 /* sched_class::task_waking was called */
1054+
#else
1055+
#define ENQUEUE_WAKING 0
1056+
#endif
10531057

10541058
#define DEQUEUE_SLEEP 1
10551059

@@ -1071,7 +1075,7 @@ struct sched_class {
10711075

10721076
void (*pre_schedule) (struct rq *this_rq, struct task_struct *task);
10731077
void (*post_schedule) (struct rq *this_rq);
1074-
void (*task_waking) (struct rq *this_rq, struct task_struct *task);
1078+
void (*task_waking) (struct task_struct *task);
10751079
void (*task_woken) (struct rq *this_rq, struct task_struct *task);
10761080

10771081
void (*set_cpus_allowed)(struct task_struct *p,

kernel/sched.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -2531,7 +2531,7 @@ static int try_to_wake_up(struct task_struct *p, unsigned int state,
25312531
p->state = TASK_WAKING;
25322532

25332533
if (p->sched_class->task_waking) {
2534-
p->sched_class->task_waking(rq, p);
2534+
p->sched_class->task_waking(p);
25352535
en_flags |= ENQUEUE_WAKING;
25362536
}
25372537

kernel/sched_fair.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -1372,11 +1372,13 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags)
13721372

13731373
#ifdef CONFIG_SMP
13741374

1375-
static void task_waking_fair(struct rq *rq, struct task_struct *p)
1375+
static void task_waking_fair(struct task_struct *p)
13761376
{
13771377
struct sched_entity *se = &p->se;
13781378
struct cfs_rq *cfs_rq = cfs_rq_of(se);
13791379

1380+
lockdep_assert_held(&task_rq(p)->lock);
1381+
13801382
se->vruntime -= cfs_rq->min_vruntime;
13811383
}
13821384

0 commit comments

Comments
 (0)