Skip to content

Commit 6dab07d

Browse files
bentissJiri Kosina
authored andcommitted
HID: rmi: make transfer buffers DMA capable
Kernel v4.9 strictly enforces DMA capable buffers, so we need to remove buffers allocated on the stack. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent b7a87ad commit 6dab07d

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

drivers/hid/hid-rmi.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,16 @@ static int rmi_set_page(struct hid_device *hdev, u8 page)
188188
static int rmi_set_mode(struct hid_device *hdev, u8 mode)
189189
{
190190
int ret;
191-
u8 txbuf[2] = {RMI_SET_RMI_MODE_REPORT_ID, mode};
191+
const u8 txbuf[2] = {RMI_SET_RMI_MODE_REPORT_ID, mode};
192+
u8 *buf;
192193

193-
ret = hid_hw_raw_request(hdev, RMI_SET_RMI_MODE_REPORT_ID, txbuf,
194+
buf = kmemdup(txbuf, sizeof(txbuf), GFP_KERNEL);
195+
if (!buf)
196+
return -ENOMEM;
197+
198+
ret = hid_hw_raw_request(hdev, RMI_SET_RMI_MODE_REPORT_ID, buf,
194199
sizeof(txbuf), HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
200+
kfree(buf);
195201
if (ret < 0) {
196202
dev_err(&hdev->dev, "unable to set rmi mode to %d (%d)\n", mode,
197203
ret);

0 commit comments

Comments
 (0)