Add a config option to change the scrape behavior for listed trackers #1306
josecelano
started this conversation in
Feature requests
Replies: 1 comment
-
R1 (summary) - I tend to agree with the analysis. Summary of Scrape Behavior Options for Whitelisted Trackers:
Industry Consensus:
Implementation Advice:
Bottom Line: Switch to excluding non-whitelisted torrents by default, offering configurable options if needed. This balances security, clarity, and efficiency while aligning with industry norms. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Relates to: #1268
Context
When the tracker is running in
listed
mode (whitelist) and the client performs anscrape
request you get a list with all requested torrents even if some of them are not included in the allowed torrents list.Current behavior
For the
announce
request, the request is rejected immediately (in the controller) and the client receives an error.For the
scrape
request, there is no check at the controller level. All requests reach the domain layer. The scrape handler includes all the requested torrents in the response. However, torrents that have not been included in the whitelist return zeroed stats.Proposal
For me, It's confusing to return always data for non-allowed torrents because there is no way to know if that torrent is not allowed or there is no data for the torrent because there are no peers yet.
I think there are some alternatives:
I think option 2 is the best because:
NOTE: If we just change the response that would be a breaking change because clients always expect to receive one item for each torrent in the response. If we decide to simply change it it should be done in the next major version. Alternatively we can add a new config option to let the admin decided which beauvoir wants to enable.
AI research
Prompt:
Claude 3.5 Sonnet (Anthropic):
o1 (OpenAI):
Gemini Flash 2.0 (Google Vertex):
Grok 2 1212 (xAI)
cc @da2ce7 @mario-nt @grmbyrn
Beta Was this translation helpful? Give feedback.
All reactions