-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: tornadoweb/tornado
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: tornadoweb/tornado
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: branch6.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 8 files changed
- 1 contributor
Commits on May 14, 2023
-
web: Fix an open redirect in StaticFileHandler
Under some configurations the default_filename redirect could be exploited to redirect to an attacker-controlled site. This change refuses to redirect to URLs that could be misinterpreted. A test case for the specific vulnerable configuration will follow after the patch has been available.
Configuration menu - View commit details
-
Copy full SHA for 32ad07c - Browse repository at this point
Copy the full SHA 32ad07cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34f5c1c - Browse repository at this point
Copy the full SHA 34f5c1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3aa6c5 - Browse repository at this point
Copy the full SHA e3aa6c5View commit details
Commits on Aug 11, 2023
-
http1connection: Make content-length parsing more strict
Content-length and chunk size parsing now strictly matches the RFCs. We previously used the python int() function which accepted leading plus signs and internal underscores, which are not allowed by the HTTP RFCs (it also accepts minus signs, but these are less problematic in this context since they'd result in errors elsewhere) It is important to fix this because when combined with certain proxies, the lax parsing could result in a request smuggling vulnerability (if both Tornado and the proxy accepted an invalid content-length but interpreted it differently). This is known to occur with old versions of haproxy, although the current version of haproxy is unaffected.
Configuration menu - View commit details
-
Copy full SHA for 217295b - Browse repository at this point
Copy the full SHA 217295bView commit details -
httpserver_test: Add ExpectLog to fix CI
The github security advisory feature lets you make private PRs but it apparently doesn't support CI so this log failure wasn't caught until after the PR was merged.
Configuration menu - View commit details
-
Copy full SHA for 7dfe8b5 - Browse repository at this point
Copy the full SHA 7dfe8b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c8a9a4 - Browse repository at this point
Copy the full SHA 5c8a9a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a9e6fb - Browse repository at this point
Copy the full SHA 6a9e6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4d6984 - Browse repository at this point
Copy the full SHA e4d6984View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...branch6.3