net: hns: Fix wrong read accesses via Clause 45 MDIO protocol

liuyonglong86 · davem330 · commit cec8abba13e6 · 2019-01-27T23:01:56.000-08:00
When reading phy registers via Clause 45 MDIO protocol, after write
address operation, the driver use another write address operation, so
can not read the right value of any phy registers. This patch fixes it.

Signed-off-by: Yonglong Liu &lt;liuyonglong@huawei.com&gt;
Signed-off-by: Peng Li &lt;lipeng321@huawei.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
@@ -321,7 +321,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum)
 		}
 
 		hns_mdio_cmd_write(mdio_dev, is_c45,
-				   MDIO_C45_WRITE_ADDR, phy_id, devad);
+				   MDIO_C45_READ, phy_id, devad);
 	}
 
 	/* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum)`
`321`	`321`	`}`
`322`	`322`
`323`	`323`	`hns_mdio_cmd_write(mdio_dev, is_c45,`
`324`		`- MDIO_C45_WRITE_ADDR, phy_id, devad);`
	`324`	`+ MDIO_C45_READ, phy_id, devad);`
`325`	`325`	`}`
`326`	`326`
`327`	`327`	`/* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/`