Skip to content

Commit 5fb5cae

Browse files
Enric Balletbo i SerraLee Jones
authored andcommitted
pwm-backlight: Enable/disable the PWM before/after LCD enable toggle.
Before this patch the enable signal was set before the PWM signal and vice-versa on power off. This sequence is wrong, at least, it is on the different panels datasheets that I checked, so I inverted the sequence to follow the specs. For reference the following panels have the mentioned sequence: - N133HSE-EA1 (Innolux) - N116BGE (Innolux) - N156BGE-L21 (Innolux) - B101EAN0 (Auo) - B101AW03 (Auo) - LTN101NT05 (Samsung) - CLAA101WA01A (Chunghwa) Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> Acked-by: Jingoo Han <jingoohan1@gmail.com> Acked-by: Thierry Reding <thierry.reding@gmail.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
1 parent dda6fde commit 5fb5cae

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

drivers/video/backlight/pwm_bl.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb, int brightness)
5454
if (err < 0)
5555
dev_err(pb->dev, "failed to enable power supply\n");
5656

57+
pwm_enable(pb->pwm);
58+
5759
if (pb->enable_gpio)
5860
gpiod_set_value_cansleep(pb->enable_gpio, 1);
5961

60-
pwm_enable(pb->pwm);
6162
pb->enabled = true;
6263
}
6364

@@ -66,12 +67,12 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb)
6667
if (!pb->enabled)
6768
return;
6869

69-
pwm_config(pb->pwm, 0, pb->period);
70-
pwm_disable(pb->pwm);
71-
7270
if (pb->enable_gpio)
7371
gpiod_set_value_cansleep(pb->enable_gpio, 0);
7472

73+
pwm_config(pb->pwm, 0, pb->period);
74+
pwm_disable(pb->pwm);
75+
7576
regulator_disable(pb->power_supply);
7677
pb->enabled = false;
7778
}

0 commit comments

Comments
 (0)