Merge pull request #100 from suppermancool/feature-sort-registrations-diazz-dev

remove get member profile for registrants tab

Author: codeMinter

dist/dev/index.js

@@ -13,7 +13,6 @@ members via API V3.
             * [new MembersService(tokenV3)](#new_module_services.members..MembersService_new)
             * [.getMemberFinances(handle)](#module_services.members..MembersService+getMemberFinances) ⇒ <code>Promise</code>
             * [.getMemberInfo(handle)](#module_services.members..MembersService+getMemberInfo) ⇒ <code>Promise</code>
-            * [.getListMemberInfo(members)](#module_services.members..MembersService+getListMemberInfo) ⇒ <code>Promise</code>
             * [.getExternalAccounts(handle)](#module_services.members..MembersService+getExternalAccounts) ⇒ <code>Promise</code>
             * [.getExternalLinks(handle)](#module_services.members..MembersService+getExternalLinks) ⇒ <code>Promise</code>
             * [.getSkills(handle)](#module_services.members..MembersService+getSkills) ⇒ <code>Promise</code>
@@ -54,7 +53,6 @@ Service class.
     * [new MembersService(tokenV3)](#new_module_services.members..MembersService_new)
     * [.getMemberFinances(handle)](#module_services.members..MembersService+getMemberFinances) ⇒ <code>Promise</code>
     * [.getMemberInfo(handle)](#module_services.members..MembersService+getMemberInfo) ⇒ <code>Promise</code>
-    * [.getListMemberInfo(members)](#module_services.members..MembersService+getListMemberInfo) ⇒ <code>Promise</code>
     * [.getExternalAccounts(handle)](#module_services.members..MembersService+getExternalAccounts) ⇒ <code>Promise</code>
     * [.getExternalLinks(handle)](#module_services.members..MembersService+getExternalLinks) ⇒ <code>Promise</code>
     * [.getSkills(handle)](#module_services.members..MembersService+getSkills) ⇒ <code>Promise</code>
@@ -106,18 +104,6 @@ This method does not require any authorization.
 | --- | --- | --- |
 | handle | <code>String</code> | Member handle. |
 
-#### membersService.getListMemberInfo(members) ⇒ <code>Promise</code>
-Gets public information on a list member.
-
-This method does not require any authorization.
-
-**Kind**: instance method of [<code>MembersService</code>](#module_services.members..MembersService)
-**Returns**: <code>Promise</code> - Resolves to the array.
-
-| Param | Type | Description |
-| --- | --- | --- |
-| members | <code>Array</code> | Array of member info. |
-
 <a name="module_services.members..MembersService+getExternalAccounts"></a>
 
 #### membersService.getExternalAccounts(handle) ⇒ <code>Promise</code>

docs/services.members.md

@@ -84,15 +84,6 @@ export function normalizeChallengeDetails(challenge, filtered, user, username) {
     registrants: challenge.registrants || [],
   };
 
-
-  _.forEach(finalChallenge.registrants, (registrant) => {
-    if (registrant.memberInfo) {
-      const { homeCountryCode } = registrant.memberInfo;
-      // eslint-disable-next-line no-param-reassign
-      registrant.countryCode = homeCountryCode || registrant.memberInfo.competitionCountryCode;
-    }
-  });
-
   // Winners have different field names, needs to be normalized to match `filtered` and `challenge`
   finalChallenge.winners = _.map(
     challenge.winners,
@@ -384,8 +375,6 @@ class ChallengesService {
     const challengeUser = username && await this.getUserChallenges(username, { id: challengeId })
       .then(res => res.challenges[0]).catch(() => null);
 
-    await this.private.memberService.getListMemberInfo(challenge.registrants || [], false);
-
     const finalChallenge = normalizeChallengeDetails(
       challenge,
       challengeFiltered,

src/services/challenges.js

@@ -48,25 +48,6 @@ class MembersService {
     return getApiResponsePayload(res);
   }
 
-  /**
-   * Gets public information on a list member.
-   *
-   * This method does not require any authorization.
-   *
-   * @param {Array} members List member info.
-   * @param {Boolean} shouldThrowError should throw error if request fail
-   * @return {Promise} Resolves to the data object.
-   */
-  async getListMemberInfo(members, shouldThrowError = true) {
-    const getHandle = async (member) => {
-      const result = await this.private.api.get(`/members/${member.handle}`);
-      // eslint-disable-next-line no-param-reassign
-      member.memberInfo = await getApiResponsePayload(result, shouldThrowError);
-    };
-    const apis = members.map(member => getHandle(member));
-    await Promise.all(apis);
-  }
-
   /**
    * Gets member external account info.
    * @param {String} handle