Skip to content

Env fixes #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Env fixes #749

merged 5 commits into from
Jul 12, 2023

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Jul 11, 2023

Related JIRA Ticket:
https://topcoder.atlassian.net/browse/LVT-134

What's in this PR?

Cleans up env variables
Converts REACT_APP_ env variables to boolean/number/null as needed.

@vas3a vas3a requested review from testflyjets and kkartunov July 11, 2023 21:36
@vas3a vas3a self-assigned this Jul 11, 2023
@vas3a vas3a requested review from testflyjets and kkartunov July 12, 2023 06:56
@vas3a
Copy link
Collaborator Author

vas3a commented Jul 12, 2023

@testflyjets @kkartunov I updated the scripts in package.json to rely on LOGICAL_ENV (exposed by CircleCI hopefully) for the build mode.

…env-vars

Changes CircleCI env var handling
@vas3a vas3a merged commit 7f981b4 into dev Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants