Skip to content

Prod Deploy - Fixing the permission issue with Copilot addition #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

vikasrohit
Copy link

No description provided.

vikasrohit and others added 2 commits December 31, 2019 12:53
…t-validatation

[HOTIFX] [DEV] consistent project data validation rules
We should check permissions to add/remove members using method checkAndGetPermissionId as it only supports case where the WHO adds/removes memeber is already a project member with proper permission. While in reality some powerful users can add/remove project members without joining.
Such permission are already checked inside Project Service, and we don't have to check it again, as legacy-project-processor get command from Kafka stream and nobody can write to Kafka stream except internal Topcoder services.
@vikasrohit vikasrohit merged commit 56f6113 into master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant