Skip to content

Commit b3a02aa

Browse files
committed
fix: consistent project data validation rules
Make validation rules for project data consistent with the Project Service.
1 parent 8f8bfa4 commit b3a02aa

File tree

3 files changed

+3
-21
lines changed

3 files changed

+3
-21
lines changed

src/services/ProcessorService.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -489,8 +489,8 @@ processCreate.schema = {
489489
payload: joi.object().keys({
490490
resource: joi.string().required(),
491491
id: joi.numberId(),
492-
name: joi.string().max(200).required(),
493-
description: joi.string().max(10000).allow('').allow(null).required(),
492+
name: joi.string().required(),
493+
description: joi.string().allow(null).allow('').optional(),
494494
directProjectId: joi.optionalNumberId().allow(null),
495495
billingAccountId: joi.optionalNumberId().allow(null),
496496
type: joi.string().max(45).required(),

test/processor.test.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -759,24 +759,6 @@ describe('Topcoder - Legacy Project Processor E2E Test', () => {
759759
}
760760

761761
if (op === 'create') {
762-
it(`test invalid parameters, string field name too long`, async () => {
763-
let message = _.cloneDeep(testMessages[0])
764-
_.set(message, 'payload.name', 'a'.repeat(201))
765-
await sendMessage(message)
766-
await waitJob()
767-
768-
assertErrorMessage(`"name" length must be less than or equal to 200 characters long`)
769-
})
770-
771-
it(`test invalid parameters, string field description too long`, async () => {
772-
let message = _.cloneDeep(testMessages[0])
773-
_.set(message, 'payload.description', 'a'.repeat(10001))
774-
await sendMessage(message)
775-
await waitJob()
776-
777-
assertErrorMessage(`"description" length must be less than or equal to 10000 characters long`)
778-
})
779-
780762
it(`test invalid parameters, string field type too long`, async () => {
781763
let message = _.cloneDeep(testMessages[0])
782764
_.set(message, 'payload.type', 'a'.repeat(46))

test/testData.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
const testTopics = {
66
create: {
77
requiredFields: ['originator', 'timestamp', 'mime-type',
8-
'payload.id', 'payload.name', 'payload.description', 'payload.type', 'payload.createdBy'],
8+
'payload.id', 'payload.name', 'payload.type', 'payload.createdBy'],
99
stringFields: ['payload.name', 'payload.description', 'payload.type'],
1010
integerFields: ['payload.id', 'payload.directProjectId', 'payload.billingAccountId', 'payload.createdBy'],
1111
testMessages: [

0 commit comments

Comments
 (0)