Skip to content

Commit 88e9494

Browse files
committed
feat: small improvements to local setup
- gitignore "api.env" which should be only used locally - provide more real work example in ReadMe for PROJECTS_API - docker-compose should run the service by default - improved sample.api.env to have more real-world env variables examples
1 parent f4f4dc4 commit 88e9494

File tree

5 files changed

+9
-11
lines changed

5 files changed

+9
-11
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ node_modules
55
.env
66
.nyc_output
77
coverage/
8+
docker/api.env

ReadMe.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ To run the Legacy Project Processor using docker, follow the steps below
9090
```
9191
KAFKA_URL=192.168.31.8:9092
9292
INFORMIX_HOST=192.168.31.8
93-
PROJECTS_API=192.168.31.8
93+
PROJECTS_API=192.168.31.8:8001/v5
9494
```
9595

9696
4. Once that is done, go to run the following command

docker/api.env

Lines changed: 0 additions & 3 deletions
This file was deleted.

docker/docker-compose.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ services:
66
build:
77
context: ../
88
dockerfile: docker/Dockerfile
9-
# env_file:
10-
# - api.env
11-
# command: run start
9+
env_file:
10+
- api.env
11+
command: run start
1212
# command: run test
13-
command: run test:cov
13+
# command: run test:cov

docker/sample.api.env

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
KAFKA_URL=<KAFKA URL>
2-
INFORMIX_HOST=<INFORMIX HOST>
3-
PROJECTS_API=<PROJECTS API>
1+
KAFKA_URL=host.docker.internal:9092
2+
INFORMIX_HOST=host.docker.internal
3+
PROJECTS_API=host.docker.internal:8001/v5
44
AUTH0_CLIENT_ID=<AUTH0 CLIENT ID>
55
AUTH0_CLIENT_SECRET=<AUTH0 CLIENT SECRET>
66
AUTH0_URL=<AUTH0 URL>

0 commit comments

Comments
 (0)