Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

fixes appirio-tech/topcoder-app/issues/940 registration link endpoint #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shubhendusaurabh
Copy link
Contributor

fixes topcoder-archive/appirio_tech-topcoder-app/issues/940 registration link endpoint issue

@birdofpreyru
Copy link
Collaborator

@shubhendusaurabh I wonder, whether you found these changes have any effect on the App? For me it seems, that your fix works equally good with or without these changes. So, I am wondering, whether they have any side-effect, rather than removing an unnecessary # from those URLs?

@birdofpreyru
Copy link
Collaborator

@ajefts I don't have write permissions in this repo, thus cannot merge this PR myself. I've done some testing, and it looks to me that removing hashes from those constants have no impact on the App behavior, other than making these constants to look a bit nicer. Thus, I'd say, let's merge it in, if you don't have any insight, why these hashes may be important there?

@shubhendusaurabh
Copy link
Contributor Author

@birdofpreyru the Join link wasn't redirecting properly for me with the '#'. Both join and login button would redirect to https://accounts.topcoder-dev.com/member. So I needed to make these changes.
After making the did you restart the webpack?

@birdofpreyru
Copy link
Collaborator

@shubhendusaurabh Oh, my bad :) I've first tested your modified version, saw it work all right, and then completely forgot that there was that redirect issue in the original code :)

@ajefts Please, merge it in, or promote my permissions in this repo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[$40] - Several fixes related to Join / Log In buttons in the top menu
2 participants