Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit d7f7109

Browse files
fixed #677 updated links
1 parent 31d4a0a commit d7f7109

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

app/directives/challenge-links/challenge-links.directive.jade

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
p(ng-switch-when="MARATHON_MATCH") {{challenge.numRegistrants[0]}}
66
p(ng-switch-default) {{challenge.numRegistrants}}
77

8-
a.submissions(ng-hide="challenge.track === 'DATA_SCIENCE'", ng-href="{{challenge|challengeLinks:'registrants'}}")
8+
a.submissions(ng-hide="challenge.track === 'DATA_SCIENCE'", ng-href="{{challenge|challengeLinks:'submissions'}}")
99
.icon.submissions-icon
1010
p {{challenge.numSubmissions}}
1111

1212
a.forum(ng-href="{{challenge|challengeLinks:'forums'}}")
1313
.icon.forum-icon
14-
p Posts
14+
p Posts

app/directives/ios-card/ios-card.directive.jade

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
p {{challenge.numRegistrants}}
1616

17-
a.submissions(ng-href="https://www.{{DOMAIN}}/challenge-details/{{challenge.id}}/?type={{challenge.track}}#viewRegistrant")
17+
a.submissions(ng-href="https://www.{{DOMAIN}}/challenge-details/{{challenge.id}}/?type={{challenge.track}}#submissions")
1818
.submissions-icon
1919

2020
p {{challenge.numSubmissions}}

app/filters/challengeLinks.filter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
};
3030
switch (type) {
3131
case 'forums':
32-
switch (challenge.track) {
32+
switch (challenge.track.toLowerCase()) {
3333
case 'develop':
3434
return String.supplant('https://apps.{domain}/forums/?module=Category&categoryID={forumId}', data);
3535
case 'data':
@@ -39,6 +39,7 @@
3939
}
4040

4141
case 'submissions':
42+
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}#submissions', data);
4243
case 'registrants':
4344
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}#viewRegistrant', data);
4445
case 'detail':

app/filters/filters.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ describe('filters', function() {
7070
expect(challengeLinksFilter(_ch, 'detail')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=develop');
7171
expect(challengeLinksFilter(_ch, 'forums')).to.be.equal('https://apps.'+domain+'/forums/?module=Category&categoryID=2');
7272
expect(challengeLinksFilter(_ch, 'registrants')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=develop#viewRegistrant');
73-
expect(challengeLinksFilter(_ch, 'submissions')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=develop#viewRegistrant');
73+
expect(challengeLinksFilter(_ch, 'submissions')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=develop#submissions');
7474
});
7575

7676
it ('should have the correct links for DESIGN challenge', function() {
@@ -83,7 +83,7 @@ describe('filters', function() {
8383
expect(challengeLinksFilter(_ch, 'detail')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design');
8484
expect(challengeLinksFilter(_ch, 'forums')).to.be.equal('https://apps.'+domain+'/forums/?module=ThreadList&forumId=2');
8585
expect(challengeLinksFilter(_ch, 'registrants')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design#viewRegistrant');
86-
expect(challengeLinksFilter(_ch, 'submissions')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design#viewRegistrant');
86+
expect(challengeLinksFilter(_ch, 'submissions')).to.be.equal('https://www.'+domain+'/challenge-details/1/?type=design#submissions');
8787
});
8888

8989
it ('should have the correct links for DATA_SCIENCE challenge', function() {

0 commit comments

Comments
 (0)