Fix NULL pointer dereference in zdb

ryao · tonyhutter · commit 5eaad8bdb5cf · 2022-12-01T12:39:42.000-08:00
Clang's static analyzer complained that we dereference a NULL pointer in dump_path() if we return 0 when there is an error. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes openzfs#14044
diff --git a/cmd/zdb/zdb.c b/cmd/zdb/zdb.c
@@ -2995,7 +2995,7 @@ open_objset(const char *path, void *tag, objset_t **osp)
 	}
 	sa_os = *osp;
 
-	return (0);
+	return (err);
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -2995,7 +2995,7 @@ open_objset(const char path, void tag, objset_t **osp)`
`2995`	`2995`	`}`
`2996`	`2996`	`sa_os = *osp;`
`2997`	`2997`
`2998`		`- return (0);`
	`2998`	`+ return (err);`
`2999`	`2999`	`}`
`3000`	`3000`
`3001`	`3001`	`static void`