Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaarli popup window doesn't have a scroll bar in Firefox. #398

Open
poVoq opened this issue Jan 30, 2018 · 5 comments
Open

Shaarli popup window doesn't have a scroll bar in Firefox. #398

poVoq opened this issue Jan 30, 2018 · 5 comments

Comments

@poVoq
Copy link

poVoq commented Jan 30, 2018

Not sure if that can be fixed easily, but the "share" pop-up for Shaarli is very hard to use on smaller screens as you can't scroll in it. The only way to use it is by pressing tab to reach all the fields. Edit: or with the markdown toolbar enabled, switching between the fullscreen mode and back resets the popup window to the top.

Also: it there an option to hide/rename the "share" button for public non-logged in view? It might confuse people with other kinds of social sharing.

@poVoq
Copy link
Author

poVoq commented Jan 31, 2018

This explains the relevant settings:
https://developer.mozilla.org/en-US/docs/Web/API/Window/open

@tontof
Copy link
Owner

tontof commented Jan 31, 2018

markdown toolbar? I'm not sure I understand what you mean by that.
For now, I've modified the scrollbar so that it will possible to scroll on this pop-up
43f0c54

For the share button, I guess the best thing is to add a custom css:

.item-shaarli {display: none;}

@tontof
Copy link
Owner

tontof commented Jan 31, 2018

Available for now only on the dev index:
https://raw.githubusercontent.com/tontof/kriss_feed/master/src/index.php

@poVoq
Copy link
Author

poVoq commented Jan 31, 2018

markdown toolbar? I'm not sure I understand what you mean by that.

In Shaarli, a plugin to allow easier markdown editing.

.item-shaarli {display: none;}

But then it would not be visible/usable at all. I would like to have it available for logged in users, or maybe better rename it to "Shaarli" so that people don't get confused.

It seems to recognize if a link was shared previously, but always opens up the Shaarli editor (or asks for a login). Better would be if it could redirect to the existing Shaarli entry in read mode (permalink) for already shared links, as thus also public readers could easily see the additional notes (and user comments if that is enabled in Shaarli). If you actually want to edit a share, then that's easily possible from within Shaarli then.

@tontof
Copy link
Owner

tontof commented Jan 31, 2018

I understand the idea for the Shaarli part, but it's too difficult and specific. The fact that it recognizes that a link was previously shared is because of Shaarli behavior and occurs only when you are logged in so that in public mode it can not be redirect on the user comments.

For the shaarli link, to hide it only in public

#index[data-is-logged=""] .item-shaarli {
    display: none;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants