New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic is used in library instead of returning error #21

Open

isodude opened this issue May 27, 2021 · 0 comments

isodude commented May 27, 2021

At

mtr/pkg/icmp/icmp.go

Line 43 in 1c17592

log.Panicf("Failed to listen to address %v. Msg: %v.", localAddr, err.Error())

the code is throwing a panic, which when using this code as a library is quite devastating.

I'm using it for a mtr plugin in telegraf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment