Why not OnPush change detection in BigInputActionComponent?

[hhubik]

Thanks for making this starter project!!

I am wondering though why none of the components use OnPush change detection. I am under the impression that one of the benefits of using "dumb" components that only receive input data and/or produce output data was that their performance could be improved by using the OnPush change detection.

It seems that at the very least BigInputActionComponent and perhaps AboutComponent should use OnPush change detection. Any thoughts on this?

[tomastrajan]

Hi @hhubik !

I am very happy that you like the starter project! The OnPush would naturally make sense in many places and also to set is as a default for the CLI when creating new components. Would you be interested in creating fork adding OnPush to relevant components and creating PR ?

Cheers!

[hhubik]

@tomastrajan I will give that a try.

[tomastrajan]

Closed by #134 , thanks again @hhubik !

[hhubik]

No problem. Glad to help!