Skip to content

Commit 5b2f752

Browse files
committed
🐛 fixed android webview issue
1 parent f60d1d7 commit 5b2f752

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## [1.4.6] - Thursday, 12.September 2019
2+
3+
### Fixed
4+
5+
- Variables and functions from injectedJavaScript not available on Android (<a href="https://github.com/react-native-community/react-native-webview/issues/554" target="_blank">see react-native issue</a>)
6+
17
## [1.4.5] - Saturday, 17.August 2019
28

39
### Added

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,12 @@ const styles = StyleSheet.create({
381381
});
382382
```
383383

384+
## [1.4.6] - Thursday, 12.September 2019
385+
386+
### Fixed
387+
388+
- Variables and functions from injectedJavaScript not available on Android (<a href="https://github.com/react-native-community/react-native-webview/issues/554" target="_blank">see react-native issue</a>)
389+
384390
## [1.4.5] - Saturday, 17.August 2019
385391

386392
### Added

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-echarts-wrapper",
3-
"version": "1.4.5",
3+
"version": "1.4.6",
44
"description": "📈Powerful React-Native ECharts Wrapper 📊",
55
"main": "src/index.js",
66
"scripts": {

src/index.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,10 @@ class ECharts extends Component {
141141

142142
getWebViewRef = ref => {
143143
this.webview = ref;
144+
145+
if (this.webview) {
146+
this.webview.injectJavaScript(jsBuilder.getJavascriptSource(this.props));
147+
}
144148
};
145149

146150
render() {
@@ -176,7 +180,6 @@ class ECharts extends Component {
176180
originWhitelist={["*"]}
177181
scrollEnabled={false}
178182
source={source}
179-
injectedJavaScript={jsBuilder.getJavascriptSource(this.props)}
180183
onMessage={this.onMessage}
181184
allowFileAccess
182185
allowUniversalAccessFromFileURLs
@@ -190,7 +193,6 @@ class ECharts extends Component {
190193
originWhitelist={["*"]}
191194
scrollEnabled={false}
192195
source={source}
193-
injectedJavaScript={jsBuilder.getJavascriptSource(this.props)}
194196
onMessage={this.onMessage}
195197
allowFileAccess
196198
allowUniversalAccessFromFileURLs

0 commit comments

Comments
 (0)