-
Notifications
You must be signed in to change notification settings - Fork 70
V3 mass upgrade #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: testing
Are you sure you want to change the base?
V3 mass upgrade #951
Conversation
You chose v3.1 instead of v3.2 as it went to stable, which downgrades some packages. Since you are updating from v2 based images, it wouldn't matter as they would still mainly be upgraded. Let's use v3.2 instead so we can avoid the issues we swapped to stable to resolve. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All recipes that were changed will need their pkgver's rel (The number after the -
) updated to trigger the package build.
This also fixes #871 as a side-effect... |
We will need to get a new version of toltecmk pushed out to include upgrading to to resolve the build issues. It probably is worth just bumping absolutely everything when we do to make sure we didn't introduce any new issues. After we get the other PR merged I'll get the toltecmk version pushed, but it may be a bit. I'm not at home and mostly on mobile or a mobile hotspot |
0.3.5 should be released with your changes. |
recipe_bundle[arch].packages[pkg_name] | ||
for pkg_name in recipe_bundle[arch].packages | ||
] | ||
logger.info("Building %s", name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it possible to figure out what package was broken!
Not needed for 3.2
Yay! With a small set of exceptions (folly, plato, retris) all of which have comments and links to their bug tickets, we have a working build with all the other 2.x packages on 3.x. |
I'll take a closer look and do some testing later this week. |
retris, chessmarkable, doomarkable and now plato all got new releases now (based on new libremarkable. features: 0.6.3 » MSRV bump: 0.7.0), so now they all build fine. See respective releases (linked above) for more as some had the one or other small improvement added as well. Also all support the env Should resolve:
|
Latest Chessmarkable certainly I can't build with v3.2, but that's a matter of the image being out of date! Logs I get are
|
Same problem for retris and plato |
Tried deleting the Cargo.lock for those projects, and downgrading to the minimum versions, but you hit tomaka/hlua#226 (among other problems) when trying that. |
Odd. I was building with the 3.2 image. And yeah, seems that going back with hlua would be hard, as before there were compilation errors due to the system library changing some function definitions. |
toltec-dev/toolchain#43 to get a newer rust with a 3.3 image appears to have sorted all of this out thankfully! |
Alright, we have them all building now this will take a while to test as there are quite a few packages, and will require testing on both OS 2.x and 3.x for both rM1 and rM2. If anybody wants to help, feel free to comment with what you've tested. We are only really looking for a quick install/uninstall test along with launching the app to make sure it runs and appears to perform it's basic functions. There is no need for an in depth test, although if you do that, make sure to raise any issues you find on the application's repository, unless it appears to be a packaging issue. |
I'm in progress testing things on my rm1 with OS 2.x, and will update this comment as I continue:
This appears to be in
So with the exception of templatectl having a weirdly borked postinst, all good here. |
It's basically a stub on the rM1, but still relevant to test that it installs properly |
templatectl issue is a build bug, see toltec-dev/build#60 |
templatectl install works all fine now |
Mass upgrade to v3 to fix #950