Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure checkers through tasks #7

Closed
AdamFrey opened this issue Mar 14, 2017 · 5 comments
Closed

Configure checkers through tasks #7

AdamFrey opened this issue Mar 14, 2017 · 5 comments

Comments

@AdamFrey
Copy link

Just wondering if you had a plan to pass arguments from the boot tasks down to the checkers themselves (like excluded namespaces, excluded linters, etc.).

Would you accept a PR that implemented some subset of argument passing or would you like to cover everything at once?

@snorremd
Copy link

Would like to see that as well. The default 80 character limit of Bikeshed is overly strict so would be very nice if I could pass the --max-line-length argument down via the check-with-bikeshed task.

@tolitius
Copy link
Owner

would -o + map not work for you?

i.e.

$ boot check/with-bikeshed -o "{:max-line-length 42}"

Checking for lines longer than 42 characters.
Badly formatted files:
## ....

@tolitius
Copy link
Owner

@AdamFrey which options are you looking to add? Some options are already supported via -o / --options, and bikeshed: https://github.com/tolitius/boot-check#bikeshed-options.

@snorremd
Copy link

snorremd commented Mar 24, 2017

@tolitius I was not aware of that option, though reading the README.md now in hindsight makes it quite obvious. Today I learned, and so forth. Then I've got everything I need, thank you.

@tolitius
Copy link
Owner

tolitius commented Apr 7, 2017

closing this. feel free to reopen if there are more questions

@tolitius tolitius closed this as completed Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants