Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting Android Text with non positional arguments leads to lint warning #2392

Open
Nailik opened this issue Jun 25, 2024 · 4 comments
Open
Assignees
Labels
enhancement New feature or request for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task hacktoberfest

Comments

@Nailik
Copy link

Nailik commented Jun 25, 2024

Describe the bug
Tolgee exports strings for Android in a way that they are reported by android lint.
This is only visible when running the build command and not directly in Android Studio.

To Reproduce
Steps to reproduce the behavior:

  1. Define a text with 2 tolgee universal placeholders for example:{0} um {1}
  2. Export for android
  3. The export is: %s um %s
  4. When building an Android project with this text there is a warning:
    Multiple substitutions specified in non-positional format of string resource string/at_with_placeholder. Did you mean to add the formatted="false" attribute?

Expected behavior
Tolgee exports should not lead to a lint warning.

Possible solutions (i would prefer if you can choose which one to use while exporting, like a selection box where you can either choose: use non-positional arguments with formatted="false" or use positional arguments.
Also allow to set it when exporting it via rest.
If the decision is to not make this selectable then use positional arguments for android because hiding warnings is always worse than fix them in the first place.

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 26, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Aug 9, 2024
@Nailik
Copy link
Author

Nailik commented Aug 9, 2024

no it's not completed! @JanCizmar the bot should really stop just closing issues.

@JanCizmar
Copy link
Contributor

Bad bot! 🤖

@JanCizmar JanCizmar reopened this Aug 9, 2024
@JanCizmar JanCizmar added enhancement New feature or request and removed stale labels Aug 9, 2024
@JanCizmar JanCizmar added the for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants