Remove json support from tracing-subscriber's default features #653 #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs#653 Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
hawkw
reviewed
Apr 4, 2020
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
Thanks for the PR! Because this is a breaking change, it won't merge until we're ready to release an 0.3 version of tracing-subscriber. However, it's very helpful to have this ready to go.
Would you mind also giving the docs a quick skim to make sure we don't state that the json feature is on by default? Thanks.
Contributor
Author
|
It will be done this weekend :) |
Contributor
Author
|
After checking the documentation it seems nothing has to be updated |
Member
|
I've changed the base branch for this PR to the |
hawkw
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
close #653