Let dead_code lint work on #[instrument]ed functions
#3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
fix-dead-code
branch
2 times, most recently
from
3a36bb1
to
b1af999
Compare
Closes (partially?) tokio-rs#1366
9999years
force-pushed
the
fix-dead-code
branch
from
b1af999
to
0928c37
Compare
9999years
changed the title
dead_code lint work on #[instrumented functionsdead_code lint work on #[instrument]ed functions
9999years
force-pushed
the
fix-dead-code
branch
from
1da5a52
to
e601fe2
Compare
9999years
force-pushed
the
fix-dead-code
branch
from
5c58b47
to
cb4d357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#[instrument]ed functions never trigger adead_codelint.Closes (partially?) #1366
Solution
Include all of the input tokens in the output. In particular, the brace tokens surrounding the function body, the parenthesis surrounding the function parameters, and the angle brackets surrounding the generics must be included.
Prior art: andrewhickman/fn-error-context@cfa749a