Skip to content

Conversation

@jtescher
Copy link
Collaborator

@jtescher jtescher commented May 10, 2021

Motivation

Support the latest OpenTelemetry specification.

Solution

Update opentelemetry to the latest 0.14.x release. Despite breaking changes upstream, no additional public API or behavioral changes are necessary in tracing-opentelemetry, but simplifications in the propagation of span information have removed the need for the current internal CompatSpan and custom parent context construction.

Performance has improved by ~30% on current benchmarks.

Resolves #1395, Resolves #1396

## Motivation

Support the latest OpenTelemetry specification.

## Solution

Update `opentelemetry` to the latest `0.14.x` release. Despite breaking
changes upstream, no additional public API or behavioral changes are
necessary in `tracing-opentelemetry`, but simplifications in the
propagation of span information have removed the need for the current
internal `CompatSpan` and custom parent context construction.

Performance has improved by ~30% on current benchmarks.
@jtescher jtescher added the crate/opentelemetry Related to the `tracing-opentelemetry` crate. label May 10, 2021
@jtescher jtescher requested review from a team, davidbarsky and hawkw as code owners May 10, 2021 01:40
Copy link
Member

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidbarsky davidbarsky merged commit bee0d48 into master May 15, 2021
@davidbarsky davidbarsky deleted the jtescher/update-otel branch May 15, 2021 18:27
jtescher added a commit that referenced this pull request May 15, 2021
## Motivation

Support the latest OpenTelemetry specification.

## Solution

Update `opentelemetry` to the latest `0.14.x` release. Despite breaking
changes upstream, no additional public API or behavioral changes are
necessary in `tracing-opentelemetry`, but simplifications in the
propagation of span information have removed the need for the current
internal `CompatSpan` and custom parent context construction.

Performance has improved by ~30% on current benchmarks.
hawkw pushed a commit that referenced this pull request May 17, 2021
## Motivation

Support the latest OpenTelemetry specification.

## Solution

Update `opentelemetry` to the latest `0.14.x` release. Despite breaking
changes upstream, no additional public API or behavioral changes are
necessary in `tracing-opentelemetry`, but simplifications in the
propagation of span information have removed the need for the current
internal `CompatSpan` and custom parent context construction.

Performance has improved by ~30% on current benchmarks.
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
## Motivation

Support the latest OpenTelemetry specification.

## Solution

Update `opentelemetry` to the latest `0.14.x` release. Despite breaking
changes upstream, no additional public API or behavioral changes are
necessary in `tracing-opentelemetry`, but simplifications in the
propagation of span information have removed the need for the current
internal `CompatSpan` and custom parent context construction.

Performance has improved by ~30% on current benchmarks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crate/opentelemetry Related to the `tracing-opentelemetry` crate.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants