-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Make cooperative and poll_proceed public #7405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
79e9505
to
ab9db65
Compare
a21ed1b
to
4ad718d
Compare
@Darksonn let me know if there's anything else I can do to help move this one along. In the meantime in DataFusion I've approximated |
@Darksonn comments addressed, only a bit unsure about unwind safety. |
@Darksonn I understand if this one is pretty low on the priorities list. Just wanted to say that from my point of view this is as complete as I can get it. Happy to continue working on it if anything specific still needs to be done. |
Overall LGTM. |
Latest round of comments processed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Terse. 😄 Thanks for the taking the time to review thoroughly and helping me stumble through the learning process. |
I'm happy to have you :) |
Motivation
In systems that use the Tokio runtime, it can be useful to integrate non-Tokio resources with the Tokio task budget. This makes it easier to ensure all tasks yield sufficiently. Currently only
consume_budget
is available, but this is impractical when trying to make certain types likeFuture
orStream
participate in cooperative scheduling.Closes #7403
Solution
Make the existing
cooperative
andpoll_proceed
methods public.Clarify the documentation of
poll_proceed
.